Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space between numerical value and unit symbol for SI output #21

Closed
spellgen opened this issue May 21, 2015 · 5 comments

Comments

@spellgen
Copy link

commented May 21, 2015

Very nice collection here. Just a niggle - SI convention calls for a space between the number and the unit: 1 m, 10 kg, 123 mS ... etc

http://physics.nist.gov/Pubs/SP811/sec07.html

@kyrofa

This comment has been minimized.

Copy link

commented Jun 3, 2015

Seconded-- should be the same for bytes.

@dmitshur

This comment has been minimized.

Copy link
Collaborator

commented Jun 3, 2015

I think I'm in favor.

@dustin

This comment has been minimized.

Copy link
Owner

commented Jun 3, 2015

It'd be fairly hard to make this configurable. I suppose it's the right thing to do, but it will take up seemingly unnecessary space in areas I use it where space is scarce and seemingly will just reduce clarity by taking logically grouped units and separating them into multiple parts.

e.g., instead of

1MB 1KB 1MB 1MB 1KB 1GB 1MB

I'd have

1 MB 1 KB 1 MB 1 MB 1 KB 1 GB 1 MB
@kyrofa

This comment has been minimized.

Copy link

commented Jun 5, 2015

dustin, it only reduces clarity when you have it ambiguously spaced like in your example. These are the SI conventions. Right now I'm using regex to put the space in there!

@dustin dustin closed this in 64dbdae Nov 9, 2015

@dmitshur

This comment has been minimized.

Copy link
Collaborator

commented Nov 9, 2015

👍

dustin added a commit to dustin/humanFormat that referenced this issue May 13, 2016

dmitshur added a commit that referenced this issue Feb 28, 2017

Add space between numbers and units in README, package documentation.
When we added space between numbers and units in 64dbdae,
the README and package documentation weren't updated. This fixes that.

Also fix various other minor issues in documentation that I found.
Use single space between sentences in README, to follow Go style.

Follows 64dbdae.
Helps #21.

dustin added a commit that referenced this issue Feb 28, 2017

Add space between numbers and units in README, package documentation.
When we added space between numbers and units in 64dbdae,
the README and package documentation weren't updated. This fixes that.

Also fix various other minor issues in documentation that I found.
Use single space between sentences in README, to follow Go style.

Follows 64dbdae.
Helps #21.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.