Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New minor release? #296

Closed
ioleo opened this issue Aug 13, 2014 · 12 comments
Closed

New minor release? #296

ioleo opened this issue Aug 13, 2014 · 12 comments

Comments

@ioleo
Copy link

ioleo commented Aug 13, 2014

The last release 0.9.0 was created on 19 Aug 2013. There are many changes since.

According to SemVer 2.0 each minor/patch change should be followed by minor/patch version change and new release.

@bobvandevijver
Copy link
Contributor

👍

It would be nice if there is a tag added before dd408d5 as it contains a BC-break.

@K-Phoen
Copy link
Collaborator

K-Phoen commented Aug 13, 2014

There have been quite a few BC breaks during the last year. So if we want to follow semver, we should release and tag a new major version. It's not a problem in itself (in fact it's even planned) but we are simply not yet ready. There are a few bugs/caveats I'd like to see fixed before that (see the milestone).

I guess we could tag a 0.10.0 version but which commit would we chose?

Anyway, I'll have time these days so I'll try to work on this bundle and release a real 1.0 version as soon as possible (not ETA though).

@ioleo
Copy link
Author

ioleo commented Aug 13, 2014

@K-Phoen could you release a 0.9.1 tag pre dd408d5 and 0.9.2 after dd408d5 ? This way we could lock dependencies in our bundles.

@K-Phoen
Copy link
Collaborator

K-Phoen commented Aug 14, 2014

Releasing a bugfix version would not make sense since there is a lot of new things and bugfixes. If we want to follow semver, I should release a major version (but we're not yet ready for that). I could release a 0.10.0 version in the next days and tag a real 1.0 when the bundle is ready (and starting from the 1.0, we could truly follow semver). WDYT?

@ioleo
Copy link
Author

ioleo commented Aug 16, 2014

@K-Phoen A 0.10.0 tag within days would be very useful. We can lock new (updated) version of our bundle on 0.10.0 then, and lock old version on 0.9.0. This would resolve our issues.

@K-Phoen
Copy link
Collaborator

K-Phoen commented Aug 16, 2014

I've made a few adjustments in the last days so I'll wait to see if there are bugs before tagging 0.10.0

Should be done in the next days though, sorry for the inconvenience ;)

@K-Phoen
Copy link
Collaborator

K-Phoen commented Aug 20, 2014

@loostro: v0.10.0 is tagged!

@K-Phoen K-Phoen closed this as completed Aug 20, 2014
@Gemorroj
Copy link
Contributor

@K-Phoen, website packagist.org still no new version. You may need to update the bundle is forced on the website packagist.org or add an interceptor on the website github.com.
1

@K-Phoen
Copy link
Collaborator

K-Phoen commented Aug 20, 2014

I can't do that since I'm not listed as maintainer... ping @dustin10 :)

@dustin10
Copy link
Owner

@K-Phoen I added you as a maintainer on packagist. I am getting spammed by packagist with the following email. Can you check it out? Thanks.

The vich/uploader-bundle package of which you are a maintainer has
failed to update due to invalid data contained in your composer.json.
Please address this as soon as possible since the package stopped updating.

It is recommended that you use `composer validate` to check for errors when you
change your composer.json.

Below is the full update log which should highlight errors as
"Skipped branch ...":

[Composer\Repository\InvalidRepositoryException]: Some branches contained invalid data and were discarded, it is advised to review the log and fix any issues present in branches

Reading composer.json of vich/uploader-bundle (v0.9.0)
Importing tag v0.9.0 (0.9.0.0)
Reading composer.json of vich/uploader-bundle (v0.8.1)
Importing tag v0.8.1 (0.8.1.0)
Reading composer.json of vich/uploader-bundle (v0.8.0)
Importing tag v0.8.0 (0.8.0.0)
Reading composer.json of vich/uploader-bundle (v0.7.0)
Importing tag v0.7.0 (0.7.0.0)
Reading composer.json of vich/uploader-bundle (v0.6.0)
Importing tag v0.6.0 (0.6.0.0)
Reading composer.json of vich/uploader-bundle (v0.5.1)
Importing tag v0.5.1 (0.5.1.0)
Reading composer.json of vich/uploader-bundle (v0.5.0)
Importing tag v0.5.0 (0.5.0.0)
Reading composer.json of vich/uploader-bundle (v0.4.0)
Importing tag v0.4.0 (0.4.0.0)
Reading composer.json of vich/uploader-bundle (v0.3.1)
Importing tag v0.3.1 (0.3.1.0)
Reading composer.json of vich/uploader-bundle (v0.3.0)
Importing tag v0.3.0 (0.3.0.0)
Reading composer.json of vich/uploader-bundle (v0.2.0)
<warning>Skipped tag v0.2.0, no composer file</warning>
Reading composer.json of vich/uploader-bundle (v0.1.0)
<warning>Skipped tag v0.1.0, no composer file</warning>
Reading composer.json of vich/uploader-bundle (1.0)
Importing branch 1.0 (1.0.x-dev)
Reading composer.json of vich/uploader-bundle (functional-tests)
Importing branch functional-tests (dev-functional-tests)
Skipped branch functional-tests, Invalid package information:
target-dir : this can not be used together with the autoload.psr-4 setting, remove target-dir to upgrade to psr-4

Reading composer.json of vich/uploader-bundle (master)
Importing branch master (dev-master)

@ioleo
Copy link
Author

ioleo commented Aug 20, 2014

@dustin10 @K-Phoen

  • Go to https://github.com/dustin10/VichUploaderBundle
  • click on Settings
  • click on Webhooks and Services on the left navbar
  • click Add service button in Services panel header
  • find and choose Packagist
  • fill your packagist Username and API Token
  • check Active
  • confirm

Note: you api key will always stay hidden, so other project maintainers can't see it

E voila! Github post-commit hook will automatically update packagist every time you merge something.

PS. Thanks for the release.

@K-Phoen
Copy link
Collaborator

K-Phoen commented Aug 22, 2014

@loostro I know how packagist works but I'm only a collaborator on this repo, I don't have access to the settings panel ;)

@dustin10 the composer.json of the functional-tests branch was indeed incorrect. I just fixed it, sorry for the spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants