📝 (Doctrine) Update docs & package suggestions #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garak
requested changes
Jan 30, 2023
garak
requested changes
Jan 30, 2023
garak
requested changes
Jan 30, 2023
There was a problem hiding this comment.
I'm not sure if you actually checked the lint errors...
In any case, here they are:
docs/known_issues.md:138:103 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
docs/known_issues.md:140:98 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
|
i sure did, the previous ones were about line length and new line at the end of the file. |
garak
approved these changes
Jan 30, 2023
|
Thank you @feymo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1344 , before finding a proper way to deal with this issue, i propose to update the documentation & package suggestion.
This way, developpers encoutering this issue will have an easy way to solve it until we implement a more independant solution