do not rely on annotations to use attributes #1357
Conversation
garak
force-pushed
the
fix-attribute-annotation
branch
from
474ac31
to
6a92547
Compare
| @@ -58,7 +59,7 @@ | |||
| "symfony/yaml": "^5.4 || ^6.0" | |||
| }, | |||
| "suggest": { | |||
| "doctrine/annotations": "If your project use doctrine-bundle:>=2.8, this package is required to use annotations or attributes", | |||
| "doctrine/annotations": "If you use doctrine/doctrine-bundle >2.7, this package is required to use annotations", | |||
There was a problem hiding this comment.
Incorrect wording here - the package is required to use annotations and attributes - not just annotations.
There was a problem hiding this comment.
the purpose of this PR is indeed allowing the use of attributes without relying on doctrine annotations
| @@ -138,16 +140,22 @@ protected function registerAnnotationStrategy(ContainerBuilder $container, array | |||
| } | |||
|
|
|||
| switch ($config['metadata']['type']) { | |||
| case 'attribute': | |||
| case 'annotation': | |||
There was a problem hiding this comment.
This does not resolve the issue because this bundle's attribute reader requires Doctrine\Common\Annotations\Reader which is part of doctrine/annotations.
With this PR, when using attributes the following error is now thrown in src/Metadata/Driver/AttributeReader.php (line 15):
Attempted to load interface "Reader" from namespace "Doctrine\Common\Annotations".
Did you forget a "use" statement for "Symfony\Component\CssSelector\Parser\Reader"?
There was a problem hiding this comment.
It should be working now
There was a problem hiding this comment.
This seems to be working for attributes 👍
There was a problem hiding this comment.
This seems to be working for attributes +1
thank you for checking. Do you have the possibility to check it for annotations too? It would be awesome
garak
force-pushed
the
fix-attribute-annotation
branch
from
0e504a7
to
a179ffe
Compare
Fix #1344