Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icon color according to theme #1372

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Conversation

feymo
Copy link
Contributor

@feymo feymo commented Mar 7, 2023

Will fix #1366
I also cleaned the file, removing unused attributes

@garak
Copy link
Collaborator

garak commented Mar 7, 2023

Could you provide a screenshot please?

@feymo
Copy link
Contributor Author

feymo commented Mar 7, 2023

Sure !
Dark mode (standard & hover/selected state)
Screenshot 2023-03-07 at 21 41 59
Screenshot 2023-03-07 at 21 41 21

Light mode (standard, hover &selected state)
Screenshot 2023-03-07 at 21 42 14
Screenshot 2023-03-07 at 21 42 26
Screenshot 2023-03-07 at 21 42 48

Copy link
Collaborator

@garak garak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@garak garak merged commit 5c84885 into dustin10:master Mar 8, 2023
@feymo feymo deleted the fix/icon-color branch March 16, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profiler icon is invisible in Symony 6.2
2 participants