Replaced EventSubscriber by listener. #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garak
requested changes
Jun 17, 2023
|
I guess the test failure depends on some lower dependencies that need to be raised |
garak
reviewed
Jun 19, 2023
| @@ -22,7 +22,7 @@ public function recomputeChangeSet(BaseLifecycleEventArgs $event): void | |||
| { | |||
| $object = $event->getObject(); | |||
|
|
|||
| $em = $event->getEntityManager(); | |||
| $em = $event->getObjectManager(); | |||
There was a problem hiding this comment.
This change is about a different issue, it should be in another PR
There was a problem hiding this comment.
You are right. How we can move it to the #1393 PR?
There was a problem hiding this comment.
Just revert it and open a new PR
garak
approved these changes
Jun 21, 2023
garak
requested changes
Jun 22, 2023
|
Can we add a test to the extension to check that the listeners are registered? In the |
garak
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the change for issue #1388.