Update example with Embedded #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garak
requested changes
Jul 19, 2023
| @@ -271,6 +271,10 @@ class Product | |||
|
|
|||
| // ... other fields | |||
|
|
|||
| // NOTE: This is not a mapped field of entity metadata, just a simple property. | |||
There was a problem hiding this comment.
What would be the purpose of this?
There was a problem hiding this comment.
Your question is about the comment? if yes it's the same as in the doc without using the Embedded.
If it's about the PR globally it's to show mapping example for Embedded, for example fileNameProperty: 'image.name', size: 'image.size'
garak
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add file property for Doctrine Embedded example to show how to map fields