Refactor: Make VichImageType class extensible by removing 'final' #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the VichImageType class by removing the 'final' keyword, thereby allowing for extension of the class. This modification maintains consistency with Symfony's practice of non-final form types, enabling developers to extend this form type to add custom functionality or modifications as needed.
garak
requested changes
Nov 5, 2023
|
@garak I'm not sure about what you are referring to. Can you precise? :) |
|
The "attr" option in this comment #625 (comment) |
The commit refines VichImageType by incorporating a default 'accept' attribute, specifying common image MIME types. This provides a sensible default, simplifying the setup for typical use cases while retaining the ability for users to override it as needed.
|
@garak Done 👍 |
garak
requested changes
Nov 9, 2023
src/Form/Type/VichImageType.php
Outdated
| @@ -43,6 +43,9 @@ public function configureOptions(OptionsResolver $resolver): void | |||
| 'image_uri' => true, | |||
| 'imagine_pattern' => null, | |||
| 'storage_resolve_method' => self::STORAGE_RESOLVE_URI, | |||
| 'attr' => [ | |||
| 'accept' => 'image/png,image/jpeg,image/gif,image/webp', | |||
There was a problem hiding this comment.
'image/*' is probably better (more synthetic and open to possible other formats)
There was a problem hiding this comment.
'image/*'is probably better (more synthetic and open to possible other formats)
Agreed, and done
…VichImageType Adjust the default 'accept' attribute in VichImageType to 'image/*' to encompass all image formats, providing a more inclusive and future-proof default setting.
garak
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the VichImageType class by removing the 'final' keyword, thereby allowing for extension of the class. This modification maintains consistency with Symfony's practice of non-final form types, enabling developers to extend this form type to add custom functionality or modifications as needed.