Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow Symfony 7 #1419

Merged
merged 1 commit into from
Dec 18, 2023
Merged

allow Symfony 7 #1419

merged 1 commit into from
Dec 18, 2023

Conversation

garak
Copy link
Collaborator

@garak garak commented Dec 8, 2023 •
edited

Fix #1413

@garak
Copy link
Collaborator Author

garak commented Dec 9, 2023

This is for now blocked by KnpLabs/KnpGaufretteBundle#282
(unless we allow for a failing build)

@RobinDev
Copy link

Minimum requirement for symfony 7 is php 8.2.

Why tests are not runned on symfony 7 + symfony 8.2 ?

@garak
Copy link
Collaborator Author

garak commented Dec 10, 2023

Minimum requirement for symfony 7 is php 8.2.

Why tests are not runned on symfony 7 + symfony 8.2 ?

I think we don't need to run every possible combination of versions, so in this case sf7 + PHP 8.3 can be enough

@garak garak merged commit 0d748cf into dustin10:master Dec 18, 2023
9 of 10 checks passed
@garak garak deleted the sf7 branch December 18, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Symfony 7
2 participants
@garak @RobinDev