Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Propel integration #176

Closed
wants to merge 35 commits into from
Closed

[WIP] Propel integration #176

wants to merge 35 commits into from

Conversation

K-Phoen
Copy link
Collaborator

@K-Phoen K-Phoen commented Dec 10, 2013

Still WIP, I open this PR so that everybody can review the code and give his opinion.

@K-Phoen
Copy link
Collaborator Author

K-Phoen commented Dec 11, 2013

Related to #175

@K-Phoen
Copy link
Collaborator Author

K-Phoen commented Dec 11, 2013

The scope of this PR is wider than just adding support for Propel. I also modified the PropertyMapping class to avoid the use of reflection-related methods to update properties (symfony/property-access FTW).

As usual a little code cleaning was done, hence the "noise" in the commits.

Doctrine ORM and ODM should work as usual and I'll write documentation for Propel.

@ftassi as usual, I'll wait for your approval/review before merging anything :)

For now, the main benefit is that Doctrine/Propel entities are no longer
required to generate file links (with Twig `vich_uploader_asset`
function for instance).

The following becomes possible:

```html+jinja
{{ vich_uploader_asset(entry, 'imageFile', 'FooBundle\Entity\Entry') }}
```

Where `entry` isn't an object but an array.

This would close the issue #138
@K-Phoen K-Phoen closed this Dec 24, 2013
@K-Phoen K-Phoen deleted the propel branch December 26, 2013 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant