Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub workflow for releases #368

Merged
merged 17 commits into from
May 1, 2021
Merged

GitHub workflow for releases #368

merged 17 commits into from
May 1, 2021

Conversation

marzocchi
Copy link
Contributor

You can see it in action in my fork: a run and a release

resolves #367

- 1.13.x
- 1.14.x
- 1.15.x
- 1.16.x
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have access to tip?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not look like, see my comment below; also for example I saw that earlier release builds, before I specified 1.16.x where done with 1.15

@marzocchi
Copy link
Contributor Author

marzocchi commented May 1, 2021

@aspacca, to wrap it up:

@aspacca
Copy link
Collaborator

aspacca commented May 1, 2021

i merged tests and build in a single file, with conditionals

indeed I would prefer different files, since we already have one for docker image

@aspacca
Copy link
Collaborator

aspacca commented May 1, 2021

also it looks like action/setup-go is a bit flaky when trying to use the latest version, setting at least the minor version seems safer

it seems that's a problem when wanting to set a minimum version defaulting to latest, that doesn't pick up really. if you pin a specific version it should be fine (but it needs maintenance)

@marzocchi
Copy link
Contributor Author

if you pin a specific version it should be fine (but it needs maintenance)

yup that's what I meant, and there's no keyword like tip

@aspacca
Copy link
Collaborator

aspacca commented May 1, 2021

yup that's what I meant, and there's no keyword like tip

got it now

@marzocchi
Copy link
Contributor Author

indeed I would prefer different files, since we already have one for docker image

splitted!

@aspacca
Copy link
Collaborator

aspacca commented May 1, 2021

can you change the badge in README.md as well?
thanks!

@aspacca
Copy link
Collaborator

aspacca commented May 1, 2021

and delete .travis.yaml

@marzocchi
Copy link
Contributor Author

can you change the badge in README.md as well?

done, but you won't see it until merge as the workflow in the main branch won't exist until then, but here's a preview from my fork.


transfer.sh Gitter Go Report Card Docker pulls Build Status


how much are you annoyed by the difference in case on the black side of the badge? :D

@aspacca
Copy link
Collaborator

aspacca commented May 1, 2021

how much are you annoyed by the difference in case on the black side of the badge? :D

I will reject the PR, that's how much I'm annoyed ;P

@marzocchi
Copy link
Contributor Author

how much are you annoyed by the difference in case on the black side of the badge? :D

I will reject the PR, that's how much I'm annoyed ;P

Ah then I need to change the whole workflow name. But then it's inconsistent with the others, so I have to change them too. Including the existing one.

Maybe something breaks...!

@aspacca aspacca merged commit 16e9444 into dutchcoders:master May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving from travis-ci to github action - HELP WANTED :)
2 participants