-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub workflow for releases #368
Conversation
.github/workflows/release.yml
Outdated
- 1.13.x | ||
- 1.14.x | ||
- 1.15.x | ||
- 1.16.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have access to tip
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does not look like, see my comment below; also for example I saw that earlier release builds, before I specified 1.16.x
where done with 1.15
@aspacca, to wrap it up:
|
indeed I would prefer different files, since we already have one for docker image |
it seems that's a problem when wanting to set a minimum version defaulting to latest, that doesn't pick up really. if you pin a specific version it should be fine (but it needs maintenance) |
yup that's what I meant, and there's no keyword like |
got it now |
splitted! |
can you change the badge in README.md as well? |
and delete |
I will reject the PR, that's how much I'm annoyed ;P |
Ah then I need to change the whole workflow name. But then it's inconsistent with the others, so I have to change them too. Including the existing one. Maybe something breaks...! |
You can see it in action in my fork: a run and a release
resolves #367