Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: root.findRouters(...).getRouterInfo is not a function #39

Closed
vale1534 opened this issue Jul 1, 2017 · 2 comments
Closed

Comments

@vale1534
Copy link
Contributor

vale1534 commented Jul 1, 2017

When jscodeshift upgrades to v0.3.32 , the following call would cause bugs:

Collection.fromPaths([], this);

Please check it!

See: dvajs/dva-cli#91

@vale1534
Copy link
Contributor Author

vale1534 commented Jul 1, 2017

我已经找出 Bug 了,原因是新版 jscodeshift 使用的 Collection 位置发生了变化,从 'jscodeshift/dist/Collection'; 变为了 'jscodeshift/src/Collection';

涉事的三个文件如下:

  1. dva-ast/lib/collections/Entry.js
  2. dva-ast/lib/collections/RouteComponent.js
  3. dva-ast/lib/collections/Router.js

vale1534 added a commit to vale1534/dva-ast that referenced this issue Jul 1, 2017
ChrisFan added a commit that referenced this issue Jul 14, 2017
Fix issue #39, in sync with jscodeshift
@sorrycc
Copy link
Member

sorrycc commented Jul 25, 2017

dva-ast@0.3.5

@sorrycc sorrycc closed this as completed Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants