Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support typescript #157

Merged
merged 7 commits into from
Oct 14, 2016
Merged

Support typescript #157

merged 7 commits into from
Oct 14, 2016

Conversation

sorrycc
Copy link
Member

@sorrycc sorrycc commented Oct 13, 2016

Modified based on #142 . Close #142

Note:

TODO:

  • Support subscription done, sample code: setup({ dispatch }, done) {}

@sorrycc
Copy link
Member Author

sorrycc commented Oct 13, 2016

cc @nikogu @benjycui

This was referenced Oct 13, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.186% when pulling 9dd4a14 on support-typescript into 58c27b6 on master.

1 similar comment
@coveralls
Copy link

coveralls commented Oct 13, 2016

Coverage Status

Coverage remained the same at 94.186% when pulling 9dd4a14 on support-typescript into 58c27b6 on master.

@coveralls
Copy link

coveralls commented Oct 13, 2016

Coverage Status

Coverage remained the same at 94.186% when pulling a91a1dc on support-typescript into 58c27b6 on master.

@coveralls
Copy link

coveralls commented Oct 13, 2016

Coverage Status

Coverage increased (+0.2%) to 94.382% when pulling 4cca243 on support-typescript into 58c27b6 on master.

@coveralls
Copy link

coveralls commented Oct 13, 2016

Coverage Status

Coverage increased (+0.2%) to 94.382% when pulling 0d62316 on support-typescript into 58c27b6 on master.

@coveralls
Copy link

coveralls commented Oct 13, 2016

Coverage Status

Coverage increased (+0.2%) to 94.413% when pulling 6413244 on support-typescript into 58c27b6 on master.

call: Function;
select: Function;
take: Function;
cancel: Function;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里需要定义 return 类型吗

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉这里不是很重要,就偷懒了。

mapDispatchToProps?: Function,
mergeProps?: Function,
options?: Object
): Function;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

export function connect(
  mapStateToProps?: Function,
  mapDispatchToProps?: Function,
  mergeProps?: Function,
  options?: Object
): Function(JSX.Element); // 这样?写法好像不对,因为如果不指定参数不会检测的吧,这个地方是强关联

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok。

@nikogu
Copy link
Member

nikogu commented Oct 13, 2016

太厉害了,这么全,膜拜 @sorrycc 👍 👍 👍 佩服...我好好学习一下咋写的

@benjycui
Copy link
Member

👍

可以考虑把 fetch 和 router 的定义 PR 到对应的仓库?如果 creator 也能参与到维护中会更好。

@sorrycc sorrycc merged commit 7c46ab8 into master Oct 14, 2016
@sorrycc sorrycc deleted the support-typescript branch October 14, 2016 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants