feat: Replace Notion database ID text field with selection menu #413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the "Database ID" text field with a selection menu that lists the databases which Notero has access to. This enables directly selecting the desired Notion database instead of having to correctly obtain and paste the database ID. Trouble with this process has been the cause of at least 15 issues: #59 #60 #62 #71 #87 #116 #193 #217 #224 #249 #292 #349 #373 #380 #387
Screenshots
Changes to polyfills
The polyfill for
Object.fromEntries
used by@notionhq/client
was not working in the Notero preferences window because the global object could not be correctly obtained. As such, the call toObject.fromEntries
has been replaced with a patch.The only other polyfills in use were
String.prototype.trimEnd
andString.prototype.trimStart
used byhtml-to-notion.ts
. In this case, we were able to replace these with the "pure" versions fromcore-js-pure
.Switching from
core-js
tocore-js-pure
was able to resolve #319.Other changes
xhtml
andxul
files are now formatted with Prettier.