Continuing the work you've done so far #1
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Dave, I also am interested in getting capy working on zig master.
First thing I did was add
iterate = true
to thebuild.zig
openDir change due to later in the build file needing iterator access and the 0.11.0 code beforehand had that.Then I just started manually digging into the errors of the atomic.Atomic stuff as well as leftover meta.trait stuff laying around from your change.
There are 5 more meta.trait references left in the codebase as of now but they are using methods that you didn't build into your trait.zig yet so I left them be temporarily.
isZigString
,hasUniqueRepresentation
, andisPtrTo
are the ones remaining.Looking forward to getting this working as well :)
I'm on zig version 0.12.0-dev.1830+779b8e259 which is just a bit ahead of where you originally targeted and it's current master.