Skipping 15 sec progress #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stamoun
reviewed
Jan 16, 2023
| method: 'GET', | ||
| }).then((body) => { | ||
| const currentProgress = Number(body.progress_ms); | ||
| SpotifyApiInstance.fetch(`/me/player/seek?position_ms=${currentProgress + 15000}`, { |
There was a problem hiding this comment.
FYI I'd rather have this 15000ms as a configurable setting, but for now it can stay that way. I'm in the process of refactoring the whole application, I'll include your change and expose the settings in the settings window...
There was a problem hiding this comment.
Yeah, I also thought about doing that, but I wanted to start with smaller changes.
|
BTW thanks for your interest, I've been trying to improve Lofi here and there (time is scarce), glad to see some other folks have interest in the app ❤️ |
Co-authored-by: Nicolas St-Amour <stamoun@gmail.com>
|
Happy I can contribute, thou I'm sure what I can change without bigger conflicts, if you are in process of rewriting the whole app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #229, I implemented the feature. Clicking on backward or forward while holding Ctrl will change the progress 15s backward or forward.