Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #22, icons autohide with expected behavior #34

Closed
wants to merge 1 commit into from

Conversation

cwjoshuak
Copy link

@cwjoshuak cwjoshuak commented Dec 16, 2019

What's this PR do?

  • Icons will autohide after 5 seconds on open if autohide is true

Notes:

  1. Removed isExpanded check in if statement, it's always true on app open so the return is executed.
  2. Added call to autoCollapseIfNeeded after setting up menu bar.

What are the relevant Git tickets?

#22

Steps to reproduce:

  1. Open Hidden bar the first time
  2. Choose option auto-hide after 5s
  3. Quit Hidden Bar
  4. Reopen
  5. Auto-hide icon after 5s

Tested on macOS, 10.15.1

edit:
I don't do many PRs, will create new branches for separate fixes in the future.

@viettrungphan
Copy link
Contributor

@cwjoshuak Thanks for your contribution, this bug we fixed with #30 feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants