Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Portability] FontXY and ScummFont fail on big-endian systems #3

Closed
dwatteau opened this issue Nov 8, 2020 · 3 comments
Closed

[Portability] FontXY and ScummFont fail on big-endian systems #3

dwatteau opened this issue Nov 8, 2020 · 3 comments
Assignees
@dwatteau
Labels
bug Something isn't working

Comments

@dwatteau
Copy link
Owner

dwatteau commented Nov 8, 2020

This was quickly tested on a ppc32 system, but it seems that FontXY and ScummFont have no endianness check, and so they just fail or give improper results on these systems.
@dwatteau dwatteau added the bug Something isn't working label Nov 8, 2020
dwatteau added a commit that referenced this issue Dec 25, 2020
@dwatteau
feat(portability): Currently refuse to launch FontXY and ScummFont on…
8ad9e23 
… big-endian systems

They're not compatible with big-endian systems yet (see issue #3).

Explicitly mark them as incompatible until this is fixed.
@dwatteau dwatteau mentioned this issue Mar 30, 2021
Merged
@dwatteau
Copy link
Owner Author

PR #24 is an attempt at fixing this.

Lots of tests will be required.

@dwatteau dwatteau self-assigned this Mar 30, 2021
@dwatteau
Copy link
Owner Author

dwatteau commented Apr 5, 2021 •
edited
Loading

When using this branch:

  • BMP output files are the same on ppc and x86 ✅
  • reimported CHAR/LFL files are on the same on ppc and x86 ✅
  • compare BMP/CHAR/LFL files on ppc, x86 with the patch and x86 without the patch ✅

i.e. the generated checksums are the same on little-endian and big-endian systems, and the output is the same on little-endian systems with or without the patch.

Tested with ATLANTIS-FLOPPY-FR, DIG-FR, LOOM-EGA-EN, MONKEY2, PASSPORT, TENTACLE-FR, ZAK-TOWNS.

dwatteau added a commit that referenced this issue Apr 5, 2021
@dwatteau
Merge pull request #24 from dwatteau/feat/move-scummrp-io-to-new-lib
604d3b6 
Move the ScummRP I/O lib to "common", so that FontXY and ScummFont gain big-endian support

Issue #3.
@dwatteau
Copy link
Owner Author

dwatteau commented Apr 5, 2021

Should be fixed by #24 which has just been merged :)

@dwatteau dwatteau closed this as completed Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dwatteau dwatteau

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dwatteau