Make FontXY and scummfont use the internal I/O lib for big-endian support #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is to have all tools using the same I/O functions, so that endianness and such is dealt in the same way in all our tools.
It's not part of ScummRp anymore, so avoid any ambiguity.
|
Quickly tested on a PowerBook G4. Needs:
|
This was referenced Mar 30, 2021
More tests are going to be needed, because I fear other cast problems.
…me the file to width-table.txt
… access to that Tested with CHAR_0001 from DIG-FR: the output is the same between ppc and x86, and with and without the change on x86. Same output, but it's a cleaner and shorter way of writing a big-endian value, now that we're using ScummIO.
|
Seems ready to be merged. I couldn't find any regression with ScummFont. I didn't test FontXY a lot, but well it's a simple one, and everything will be tested again for the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #3.
scummtrandscummrpuse ScummRpIO and so they're compatible with big-endian systems.FontXYandscummfontdon't use this, and are just hardcoded to little-endian.So, let's move ScummRpIO to a dedicated common lib, and use it everywhere, so that all tools are now compatible with big-endian systems too.