Setup refresh #814
Setup refresh #814
Conversation
arcondello
force-pushed
the
setup-refresh
branch
2 times, most recently
from
5f2bd9a
to
bce20df
Compare
arcondello
force-pushed
the
setup-refresh
branch
3 times, most recently
from
1a6690a
to
f80bf25
Compare
setup.cfg
Outdated
| License :: OSI Approved :: Apache Software License | ||
| Operating System :: OS Independent | ||
| Programming Language :: Python :: 3 :: Only | ||
| Programming Language :: Python :: 3.5 |
pyproject.toml
Outdated
| @@ -0,0 +1,8 @@ | |||
| [build-system] | |||
| requires = [ | |||
| "setuptools", | |||
There was a problem hiding this comment.
I'd lower-bound setuptools to avoid some issues we had in past. Although, I can't remember what those were, but I remember it was something. 😄 Environment markers, right?
There was a problem hiding this comment.
Set it to >=42.0.0 for now. A bit arbitrary but that's the version that started supporting pep518 so seemed natural :) I have no doubt that we will want to tighten the bound approximately 10 min after I merge.
There was a problem hiding this comment.
I've found the lower-bound I had in mind -- looks like it's 31.0 due to namespace packages support.
OTOH, I'm not sure where is 42.0.0 coming from? Looking at pypa/setuptools#651, seems like PEP-518 support was not needed/not implemented in setuptools.
There was a problem hiding this comment.
Then again, I see from pypa/setuptools@89155ab the full PEP-420 support (native namespace packages) is only available since 40.1.0.
We're not using them (yet), but it seems prudent to use setuptools that supports them.
There was a problem hiding this comment.
I think the number came from their changlog.
arcondello
force-pushed
the
setup-refresh
branch
from
f80bf25
to
ac723fc
Compare
New Features ------------ * Support PEP518 for building the package #814 * Add `cyVariables.size()` and `.at(..)` to improve cython access to the `Variables` object * Add new `QuadraticModelBase` and `BinaryQuadraticModel` implementation in c++ #818, #819 Fixes ----- * Fix broken documentation links #815
Significantly rework/simplify the setup script.
Closes #678