Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PEP 518 support #651

Closed
jayvdb opened this issue Jul 14, 2016 · 4 comments
Closed

Implement PEP 518 support #651

jayvdb opened this issue Jul 14, 2016 · 4 comments

Comments

@jayvdb
Copy link
Contributor

jayvdb commented Jul 14, 2016

https://www.python.org/dev/peps/pep-0518/

pyproject.toml, if it exists, should be used like setup_requires.

See also pypa/pip#3691

@tuukkamustonen
Copy link

tuukkamustonen commented Oct 19, 2017

This seems to be supported in the forthcoming pip 10.0.

What is there to support on setuptools side? python setup.py install?

What is the plan in general - easy_install seems more or less deprecated, and pip install . (or pip install -e .) has pretty much replaced python setup.py install (or python setup.py develop). Pip seems to be the blessed tool these days. Is there any benefit in supporting two different ways (setup.py install vs pip install) for the same thing?

(pyproject.toml seems to be slowly crawling in and (while very limited at the moment) might even replace setup.py altogether?)

@pganssle pganssle added Needs Triage Issues that need to be evaluated for severity and status. enhancement Needs Discussion Issues where the implementation still needs to be discussed. and removed Needs Triage Issues that need to be evaluated for severity and status. labels Oct 19, 2018
@pganssle
Copy link
Member

@jaraco @benoit-pierre Is the plan here to have all PEP 518 go through pip? If so, I think we can close this as it's fixed in pip.

For the most part, PEP 518 support is difficult or impossible to achieve using the current approach, but I have created #1515 proposing a possible way forward that doesn't completely drop support for custom setup commands.

@jaraco
Copy link
Member

jaraco commented Aug 28, 2019

I believe the vision (and my perspective) is that setuptools aims to be a target for pep 517/518 and other libraries (pip, pep517) will implement the designs of the PEPs. So my instinct is indeed "won't fix".

@pganssle pganssle added wontfix and removed Needs Discussion Issues where the implementation still needs to be discussed. labels Aug 28, 2019
@pganssle
Copy link
Member

Agreed, let's close and revisit later if things change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants
@jayvdb @tuukkamustonen @jaraco @pganssle and others