Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible typo on lines 417 & 420 #5

Closed
adam-douglass opened this issue Oct 27, 2017 · 2 comments
Closed

Possible typo on lines 417 & 420 #5

adam-douglass opened this issue Oct 27, 2017 · 2 comments
Assignees
Labels

Comments

@adam-douglass
Copy link
Contributor

Looks like there is an extra 'not' in the logic that is preventing dates from being passed through.

@adam-douglass adam-douglass self-assigned this Oct 27, 2017
@randomir
Copy link
Member

Based on fd86de8, lines 417/420 are lines 507 and 510 in current master (c340660):

if future.time_received is not None and 'submitted_on' in message and message['submitted_on'] is not None:

if future.time_solved is not None and 'solved_on' in message and message['solved_on'] is not None:

@randomir
Copy link
Member

Confirmed, the logic is reversed due to not. Timestamps are never parsed and never set on future (see #109).

randomir added a commit to randomir/dwave-cloud-client that referenced this issue Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants