Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: ping/sample not properly outputting some errors, like polling timeout #517

Closed
randomir opened this issue Apr 15, 2022 · 0 comments · Fixed by #518
Closed

CLI: ping/sample not properly outputting some errors, like polling timeout #517

randomir opened this issue Apr 15, 2022 · 0 comments · Fixed by #518
Labels

Comments

@randomir
Copy link
Member

For example:

$ dwave ping --polling-timeout 0.00001 --json
{..., "error": ""}

The error field should contain a polling timeout error description.

As a result, tests.test_cli.TestCliLive.test_ping_json_timeout_error is also failing with:

======================================================================
FAIL: test_ping_json_timeout_error (tests.test_cli.TestCliLive)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/radomir/work/dwave-cloud-client/tests/test_cli.py", line 468, in test_ping_json_timeout_error
    self.assertEqual(result.exit_code, 9)
AssertionError: 127 != 9
@randomir randomir added the bug label Apr 15, 2022
randomir added a commit to randomir/dwave-cloud-client that referenced this issue Apr 15, 2022
randomir added a commit to randomir/dwave-cloud-client that referenced this issue Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant