Add cookie notice #146
Merged
Add cookie notice #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randomir
reviewed
May 15, 2019
| margin-left: 2em; | ||
| white-space: nowrap; | ||
| vertical-align: middle; | ||
| } |
There was a problem hiding this comment.
This is Leap theme banner on RtD theme. It just doesn't feel right. 😄
There was a problem hiding this comment.
Btw, to use something closer to RtD, it's enough to change the accept button. A few lines:
- font-size: 14px;
+ font-size: 16px;
- background: radial-gradient(circle, #4C71C6 0%, #002B86 100%);
+ background: rgb(41, 128, 185);
- text-transform: uppercase;
- letter-spacing: 1.2px;
There was a problem hiding this comment.
Will change, thanks
| $(document).ready(function () { | ||
| var cookieDiv = document.createElement('div') | ||
| cookieDiv.id = 'cookie-notice' | ||
| cookieDiv.innerHTML = "<p style='margin: 1em'>Privacy and Cookies: This site uses cookies. By continuing to use this website, you agree to their use. To find out more, see our <a style='color:#4c71c6; text-decoration: underline;' href='https://cloud.dwavesys.com/leap/legal/privacy_policy/' target='_blank'>Privacy Policy</a>.<button id='cookie-accept' class='cookie-button'>Close and Accept</button></p>" |
There was a problem hiding this comment.
We're actually using Google Analytics, and Google is storing the cookie, not DWave.
The privacy policy (used on Leap) does mention sharing of user's data with 3rd party services that act on our behalf, but should here actually Google ask for user's permission, and say they'll share the analytics with DWave?
|
@randomir, I think this can be merged now, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@randomir, can you take a quick look so I can do the same for dwave_tabu, thanks!