merge exaile team master with my own repo #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 69.5% (742 of 1068 strings)
Python 3.8 (default in msys2 now) requires a recent development snapshot of PyInstaller. Our exaile/pyinstaller fork now has an additional branch, sdk-py3, with exaile-specific changes from the sdk branch merged with pyinstaller's development branch. Recent versions of PyInstaller in turn require pywin32-ctypes 0.2.0 or later.
Use error() to display exception information in the try/catch block surrounding the exaile.main() call. The input() call in the exception handling block was causing another exception in situations when console is not available (i.e., pyinstaller build). And this way, we can get the traceback displayed in the error dialog, which makes things easier to debug.
In PyInstaller builds with console disabled, faulthandler.enable() triggers an exception (see pyinstaller/pyinstaller#4481).
…CellRendererText Fixes warnings about missing 'weight' property when columns with cell renderers different from Gtk.CellRendererText are enabled (e.g., rating column).
They've been collecting dust since 2009.
* Add label-for and labelled-by to a bunch of things * Add tooltip-text or accessible-name to some other things * Remove the has-tooltip property where it's wrong has-tooltip means we want to connect to the query-tooltip signal. If we provide the tooltip in tooltip-text then we're not supposed to set has- tooltip. The accessibility bugs are found with gla11y. See: #688
Alternatively, if the icon name already specifies -symbolic, the non- symbolic variant is used as fallback. I don't know why we previously specified NO_SVG. Now we don't, and I've added USE_BUILTIN as well, for good measure. This commit fixes Exaile failing to launch on KDE Neon, where only the Breeze icon theme is installed (no Adwaita). Breeze has 'starred-symbolic' but not 'starred', and it's in SVG format. Fixes: #690
Currently translated at 100.0% (1068 of 1068 strings)
Also change the format a bit, from "{w} x {h} pixels {z}%" to "{w}x{h}
pixels ({z}%)".
Currently translated at 10.5% (113 of 1068 strings)
Currently translated at 77.1% (824 of 1068 strings)
Currently translated at 100.0% (1068 of 1068 strings)
Currently translated at 100.0% (1068 of 1068 strings)
In _on_playback_track_end(), we need to check whether self.timer is valid before calling GLib.source_remove on it (e.g., it may be invalid if moodbar initialization fails).
uri needs to be encoded before being passed to sha256(), and we need to concatenate strings, not bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.