New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be able to disable sonar format drivers #368
Comments
- `if BUILD_GSF` is used in Makefile.am - `#ifdef ENABLE_GSF` in C files - Defaults to having GSF enabled - A start to dwcaress#368
Kurt, |
* Allow disabling of the GSF format driver. - `if BUILD_GSF` is used in Makefile.am - `#ifdef ENABLE_GSF` in C files - Defaults to having GSF enabled - A start to #368
Hey Dave, Thanks for adding the context of GSF for those who don't know. I've come to realize that I have no hope for influencing the Navy and Leidos beyond getting the to add an open source license to the code. I've met with the Admiral in charge at the time and many other folks from the Navy and Leidos. They were clear that my worries about GSF and the process around the maintenance of GSF were not going to be addressed. Using the GSF libraries is functionally equivalent to running an old version of Adobe Flash w.r.t. the view of an attacker. I've done all the warning I can at this point. PR #369 concludes what I wrote about in 2013: AUTOCONF/AUTOMAKE CHANGES TO MB-SYSTEM FOR CONDITIONALLY REMOVING GSF Notes from 2008 and 2010: OPEN SOURCE AND GSF - THE "GENERIC SENSOR FORMAT" FOR MULTIBEAM SONARS where I wrote: "It is super important to note that SAIC is only able to work on GSF based on its contracts with the US Navy" Using the GSF code in a "secure environment" (e.g. within Sabre) gives me the heebie jeebies. And it should make easy starter material for an orange team |
It would be nice to be able to control which formats are built into mb-system for several reasons:
For a note on GSF: I reported a number of issues with GSF (some more than 10 years ago) and have gotten no acknowledgements or fixes. Many of these issues are with improper handling of pointers. The GSF development process happens behind closed doors. It isn't clear how testing is done and if any code auditing is done. c.f. https://github.com/schwehr/generic-sensor-format/issues
The text was updated successfully, but these errors were encountered: