Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable pgn-at-pos test for point-min, with new value #209

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Enable pgn-at-pos test for point-min, with new value #209

wants to merge 3 commits into from

Commits on Jun 6, 2023

  1. pedantic: shorter docstring length

    @rolandwalker
    rolandwalker committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    55682c9 View commit details
    Browse the repository at this point in the history

  2. note temporarily disabled tests with TODOs

    @rolandwalker
    rolandwalker committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    8cd5e75 View commit details
    Browse the repository at this point in the history

  3. enable pgn-at-pos test for point-min w/new value 

    This always was a corner case per the docstring.  What is the meaningful
PGN at point-min?  The new code says it is the full set of header
tagpairs; the old code said the first tagpair.  Both seem acceptable.
Neither include any moves.
    @rolandwalker
    rolandwalker committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    f488222 View commit details
    Browse the repository at this point in the history