Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for value translation with select/multiselect attributes when is_configurable=0 and scope is global #556

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thedotwriter
Copy link

Hi Dweeves,

I need to be able to translate values for select attributes which are "global" but are not set to be configurable attributes. That's not possible at the moment based on the current logic.

I've read what you've said on #358 about why you choose to force store scope for configurable attributes, but I think you've got to do it not only for configurable attributes but for all select/multiselect attributes in the global scope.

I've made the change and it works. Please have a look when you've got time.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant