Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing scope issue with 'is_configurable' attribute setting' #358

Merged
merged 2 commits into from
Nov 4, 2015

Conversation

stormearthfire
Copy link
Contributor

There's no need to check 'is_configurable' attribute. By default in Magento all attributes which can be used to create configurable products MUST be global. You can check this easily in Magento admin, when adding a new attribute - if you change scope the option "Use To Create Configurable Product" will appear/disappear.

On the other hand, many of the predefined attributes that come with Magento installation, such as "price", for some reason have set 'is_configurable' to 1. This results in a bug where prices get updated only in a default store, but not in the store which is actually stated in the data source, as price is treated as a global attribute.

Issue is described in #265 as well.

@EmperorKonstantin
Copy link

@seb4C, unfortunately, this creates an issue for stores that have magmi importing different currency prices for multiple websites in Magento. The default behaviour of Magmi was changed in ver 7.2.1, and a few of us cannot upgrade to latest versions of Magmi because of the way it started treating certain attributes. The current default behaviour is update prices globally and ignore prices in website scope. This is wrong, as there is a setting for allowing prices to have website scope in Magento, which allows storeowners to have different prices based on currency and not rely on the unreliable built-in Currency Converter.

@dweeves
Copy link
Owner

dweeves commented Oct 30, 2015

i think the good fix would be to make an exception for price and let other
configurable attributes be set with the current algorithm

2015-10-30 18:20 GMT+01:00 Apofis notifications@github.com:

@seb4C https://github.com/seb4C, unfortunately, this creates an issue
for stores that have magmi importing different currency prices for multiple
websites in Magento. The default behaviour of Magmi was changed in ver
7.2.1, and a few of us cannot upgrade to latest versions of Magmi because
of the way it started treating certain attributes. The current default
behaviour is update prices globally and ignore prices in website scope.
This is wrong, as there is a setting for allowing prices to have website
scope in Magento, which allows storeowners to have different prices based
on currency and not rely on the unreliable built-in Currency Converter.


Reply to this email directly or view it on GitHub
#358 (comment).

@stormearthfire
Copy link
Contributor Author

Got it, I did as you suggested, a price is excluded from setting the scope through is_configurable setting, I tested on various store/attribute data, works fine.

dweeves added a commit that referenced this pull request Nov 4, 2015
Fixing scope issue with 'is_configurable' attribute setting'
@dweeves dweeves merged commit 7d94b5e into dweeves:master Nov 4, 2015
@dweeves
Copy link
Owner

dweeves commented Nov 4, 2015

Thx for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants