Coveralls cleanup #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review. With this, it looks like we still have one genuine missed line, but I feel pretty good about 99.853% coverage. And I feel much better to actually see the coverage reports in PRs. |
sroet
approved these changes
Aug 14, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coveralls has been (silently) failing since coverage 5 was released (late 2019). This brings coveralls back to our PRs (by switching from the defunct
python-coverallstocoveralls) and excludes from coverage a few things that are no longer expected to be covered by tests (stuff for Python 2 and pandas < 1.1).The things that are currently excluded should, at some point, be removed. But I see no reason to rush to break things that work for some users -- besides, we haven't officially updated to require these more recent versions; just we don't guarantee that the old versions will continue to work.