Keys for non-url friendly filenames are getting encoded multiple times.

[jimjeffers]

Hi, I posted my problem on SO but I think it would be better served here. Original question can be seen here:

http://stackoverflow.com/questions/19645506/how-can-i-force-url-friendly-filenames-when-using-carrierwavedirect-in-ruby-on-r

I have users uploading files with non url friendly names. Mainly, filenames that include spaces. I have an admin area where moderators can approve a photo. In the admin tool the image_url works just fine. The image path is url escaped with %20 in place of the spaces. The trouble is when the moderator approves the photo I make a simple asynchronous JSON POST request which in simply does this:

 def approve
    photo = Photo.find(params[:id])
    status = photo.update_attribute :approved, true

    respond_to do |wants|
      ...
    end
  end

As a result of that call to update_attribute I see a SQL statement like this:

SQL: (1.7ms) UPDATE "photos" SET "approved" = 't', "image" = '02216914-1e9e-4b63-8ae6-80e24cb87f7a/5918%25201%2520photo.jpg', "updated_at" = '2013-10-29 05:31:31.779058' WHERE "photos"."id" = 302

Now the image path is broken as the database is storing a twice encoded string when the internal string shouldn't be encoded at all. At least, I don't think it should. I do not know why the image attribute is also being updated during this call. Any idea why this is and/or is there a better way to be managing non url-friendly filenames from user generated content?

• Jim

[beebox]

I'm seeing the same issue as well.

[JohnBernas]

Same here.

From what I could gather, this happens in carrierwave_direct/uploader.rb, def key method, when we derive the key from the url

self.key = URI.parse(URI.encode(url)).path[1 .. -1] # explicitly set key

if the url contains %20 (encoded spaces) when you encode again, it'll encode the % to %25, resulting in the final %2520.

If I replace the code above with

self.key = URI.decode(URI.parse(url).path[1 .. -1]) # explicitly set key

it seems to work, decoding the %20 to regular spaces again.

[remino]

+1 on this issue.

Sadly, the change proposed by @JohnBernas is not working for me.

[remino]

I changed the line mentioned above in master with the following:

self.key = URI.decode(URI.parse(URI.encode(url, " []+()")).path[1 .. -1]) # explicitly set key

That worked for me.

[nddeluca]

@remino Would you mind submitting a pull request with your change?

[remino]

Sure. Just sent a pull request: #124.

[p8]

This should be fixed on master with #155