Define item type: Task or Note

[SimonLab]

ref: dwyl/app#266 (comment)
An item can be either a task or a note.

• Create a new migration to add a boolean task field (default true)
• Update changeset to cast the field task
• Update captures tests to add and test the task field

[SimonLab]

To create the many_to_many association between captures and tags I had to remember how to do this with Ecto:

• https://medium.com/coletiv-stories/ecto-elixir-many-to-many-relationships-66403933f8c1
• The chapter constraints and upserts from the little Ecto cookbook is also a great help to understand the relation and how to avoid race condition errors.

[SimonLab]

The tags table doesn't contains any items at the moment.
We can create a seed files to add the task and note tags.
We also need to add the /api/tags endpoint to get all the tags created by the authenticated user. This will allow the user to see which tags can be added to a capture or to create new ones if they don't exist yet.
This endpoint should also return the default tags, ie the ones where the id_person field is null (created by the seed)

[SimonLab]

At the moment the coverage is not great: #16 (comment)

• Add tests to make it better, see https://github.com/dwyl/phoenix-chat-example for an example of a testing Phoenix application

[SimonLab]

While updating the captures test the following error occurs:

** (Postgrex.Error) ERROR 23502 (not_null_violation) null value in column "inserted_at" violates not-null constraint

The following comments explain that with Repo.insert_all the timestamps() function used in the schema is not used: https://elixirforum.com/t/not-null-violation-on-seeding-my-database-timestamps-macro-failing/19858

I'm using insert_all to insert all the tags of a capture:

app-api/lib/app_api/captures/capture.ex

Lines 44 to 48 in 14bff08

	defp insert_and_get_all(tags, id_person) do
	maps = Enum.map(tags, &%{text: &1, id_person: id_person})
	Repo.insert_all(Tag, maps, on_conflict: :nothing)
	Repo.all(from t in Tag, where: t.name in ^tags)
	end

We can update manually the timestamp fields with:

data =
  data
    |> Enum.map(fn(row) ->
        row
          |> Map.put(:inserted_at, Timex.now)
          |> Map.put(:updated_at, Timex.now)
      end)

Repo.insert_all(Table, data)

see also: elixir-ecto/ecto#1932

[SimonLab]

The context files are now fully tested.
Most of the remaining files to test are the controllers and the view.
Because the controller is using the view I think only testing the controllers should also cover the views.
The main difficulty is to create a valid jwt to be able to test the private endpoints/controller.

[SimonLab]

I've tested different way to be able to test the controllers that requires a jwt in the request headers and the easier one at the end is to update the plug authentication function to add a condition depending on the running environment:

  def call(conn, _) do
    if Mix.env() == :test do
      assign(conn, :person, %{email: "email", name: "name", id_person: 42})
    else
      case AppApiWeb.AuthServiceApi.get_person_information(conn) do
        {:error, _} -> unauthorized(conn)
        {:ok, person} -> assign(conn, :person, person)
      end
    end
  end

This way we avoid calling the external authentication system and we bypass all the Google/Github Oauth request flow.