Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage images with Assets module #4

Closed
1 task done
SimonLab opened this issue Feb 14, 2020 · 1 comment
Closed
1 task done

Manage images with Assets module #4

SimonLab opened this issue Feb 14, 2020 · 1 comment
Assignees
Projects

Comments

@SimonLab
Copy link
Member

SimonLab commented Feb 14, 2020

To add assets to the application (e.g. images) we can create a Asset.elm module which will take the responsibility to expose the correct images' src in the application.
Having this single source of truth make it easier to change the names of the assets without having to change it on all the application.

An example of this Assets module can be found here: https://github.com/rtfeldman/elm-spa-example/blob/master/src/Asset.elm

  • Add the dwyl logo to the application using the Asset module
@SimonLab SimonLab added the T25m label Feb 14, 2020
@SimonLab SimonLab self-assigned this Feb 14, 2020
@SimonLab SimonLab added this to To do in dwyl app via automation Feb 14, 2020
@SimonLab SimonLab moved this from To do to In progress in dwyl app Feb 14, 2020
SimonLab added a commit that referenced this issue Feb 14, 2020
@SimonLab SimonLab mentioned this issue Feb 14, 2020
SimonLab added a commit that referenced this issue Feb 14, 2020
@SimonLab SimonLab moved this from In progress to Awaiting review in dwyl app Feb 14, 2020
nelsonic added a commit that referenced this issue Feb 14, 2020
@SimonLab
Copy link
Member Author

see PR #5

dwyl app automation moved this from Awaiting review to Done Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
dwyl app
  
Done
Development

No branches or pull requests

1 participant