-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initialise elm application with routes #2
Conversation
- Clone this repository: `git clone git@github.com:dwyl/app-mvp-elm.git && cd app-mvp-elm` | ||
- Install elm-live, see https://github.com/wking-io/elm-live | ||
- Run `elm-live src/Main.elm --pushstate -- --outpute elm.js --optimize` see https://github.com/dwyl/learn-elm/issues/156 | ||
- Visit localhost:8000 to see the application |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider adding more docs on what the person should expect to see when they boot the App. 💭
@@ -0,0 +1,6099 @@ | |||
(function(scope){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimonLab do we want to be adding the (compiled) elm.js
file to GitHub?
is it not redundant if people are using elm-live
to run it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment unfortunately I need this file to be on the commits.
I'm using it on Heroku and I haven't find a way to create this file on compilation with the Heroku static buildpack yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh ... 💭
The way we did it on OA was to compile it on CI and upload the compiled file to S3. 💡
But that's overkill for this MVP (for now).
OK. let's just merge the compiled file for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using the same method to deploy Elm as described here: dwyl/elm-pwa-example#3 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimonLab setup + routes looks good. 👍
Just one question about elm.js
before merging. (do we need the compiled file in .git
?)
Thanks. ☀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimonLab thanks for answering my question regarding the compiled file.
Happy to merge when you assign back to me.
(we can add more documentation later...)
ref: #1
Create the Elm application which manages three routes (for now): home page, authentication page and 404 page.
Testing the different endpoint are parsed correctly: "/" and "/auth"