-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth urls #7
Auth urls #7
Conversation
@@ -27,19 +30,21 @@ main = | |||
|
|||
type Page | |||
= Home | |||
| Auth | |||
| Auth (Maybe String) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the Maybe String
represent the query parameter jwt
on the auth endpoint.
This endpoint can be /auth
then jwt is Nothing
or /auth?jwt=...
then the value is Just ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimonLab I still have a strong preference for handling all auth on the server including displaying the buttons in SVG + CSS then redirecting back to the Elm App once the person has authenticated with the 3rd Party OAuth Provider. Server side auth reduces complexity and improves maintainability without sacrificing UX.
Having reiterated that, I think the code you have written here looks good and look forward to seeing your continued progress. 👍
Thanks for merging.
I'll write down an issue with the requirement on https://github.com/dwyl/auth-mvp/, I think I had misunderstood where the authentication (ie google and gihtub signin button) page was supposed to be rendered. |
If we render the Auth on the server it can be rendered on any platform. What I'd say is keep going with what you are doing because it's a valid approach. |
ref: #6
Allow user to login with Github or Google