Deploy run as part of CI job fails silently

[lennym]

If the deployment of a lambda fails for missing Role credentials in the environment variables then the process still exits with a zero exit code and CI environments report that the deployment was successful until you view the logs to find errors.

Failed deployments should exit with a non-zero exit code.

[tomgco]

👍 This also exhibits itself when no credentials are supplied.

[nelsonic]

@lennym good point. should it throw an error if the credentials aren't set or if deploy errors?
(how did you see this, deploying locally or from a particular Lambda?)

[lennym]

It was the deployment job for the new filter provider lambda in codeship.

Local deployments aren't so much of an issue since generally they'll be done by a person monitoring the logs, and not paying too much attention to the exit code.