-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support passing a Readable stream as the stub for S3.GetObject #144
Conversation
@jstewmon this PR looks promising! please link to an issue https://github.com/dwyl/aws-sdk-mock/issues for context. thanks! 👍 |
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
==========================================
+ Coverage 99.06% 99.08% +0.01%
==========================================
Files 1 1
Lines 107 109 +2
==========================================
+ Hits 106 108 +2
Misses 1 1
Continue to review full report at Codecov.
|
2af6d5d
to
ff7b0b1
Compare
- swapped tape with tap to get afterEach, so that the sandbox can be predictably restored after each test. - removed all restore calls that do not test restore feature - skipped the test about a stub being returned because that behavior only applies when the service constructor has already been called when mock is called. the test previously passed due to side effects of unrestored sandbox.
ff7b0b1
to
26f3975
Compare
LGTM? |
@nelsonic Yes, because the AWS SDK docs say:
Example:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jstewmon |
awesome, thank you! |
predictably restored after each test.
only applies when the service constructor has already been called when
mock is called. the test previously passed due to side effects of
unrestored sandbox.
fixes #142