Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heroku buildpack static #3 #10

Merged
merged 36 commits into from
Jan 8, 2020
Merged

Heroku buildpack static #3 #10

merged 36 commits into from
Jan 8, 2020

Conversation

SimonLab
Copy link
Member

@SimonLab SimonLab commented Jan 8, 2020

Using https://github.com/heroku/heroku-buildpack-static to host the Elm application on Heroku.
This allow us to remove npm pakage http-server.
ref: #3 (comment)

@SimonLab
remove phoenix code
a9db803
@SimonLab
initialise elm app structure
8de5e89
@SimonLab
copy elm Browser.application demo for testing deployment on Github
d7d9f98
@SimonLab
capture text with api
a79a33b
@SimonLab
add service worker
47615ea
@SimonLab
make application load offline, #56
bc65d55
@SimonLab
define start url for pwa
216aab0
@SimonLab
use heroku url for api, #55
f878147
@SimonLab
udpate url for gh-pages
74df4a7
@SimonLab
update sw cache link
a0a9c20
@SimonLab
udpate cache name
29b1ddd
@SimonLab
add assets folder, #4
e7f5a23
@SimonLab
style Capture view with Tachyons, #4
e6c1dba
@SimonLab
apply tachyons styling, #4
05cb895
@SimonLab
detect connection status and display offline icon, #5
68467d5
@SimonLab
display offline icon, #5
2ee267e
@SimonLab
apply lighthouse suggestions
99e1ae4
@SimonLab
add meta description
00a4c4d
@SimonLab
udpate url path for service worker
ef81bdc
@SimonLab
add scope for service worker
b063020
@SimonLab
add scope for service worker
0745a92
@SimonLab
update link service worker to /
2802386
@SimonLab
use /elm-pwa-example base url for service worker
5016dfa
@SimonLab
update link for service worker to test with Githug pages
ed1f5a4
@SimonLab
update start_url in manifest
13adc86
@SimonLab
create simple http server with nodejs, #3
77595c1
@SimonLab
resolve pwa audit issue, #7 (comment)
0f008d7
@SimonLab
fix theme-color and attempt redirect to https, #7 (comment)
0a3690b
@SimonLab
remove ssl option from http-server
cb46bf0
@SimonLab
add canonical url
36faec9
@SimonLab SimonLab requested a review from nelsonic January 8, 2020 12:03
nelsonic
nelsonic reviewed Jan 8, 2020
View reviewed changes
README.md
# Why
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. thanks!

nelsonic
nelsonic approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@nelsonic nelsonic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab looks good. 👍

Note: I would prefer to keep the .travis.yml file so we can independently check that everything is working. 💭

@nelsonic nelsonic merged commit 7ab35e3 into master Jan 8, 2020
@nelsonic nelsonic deleted the heroku-buildpack-static-#3 branch January 8, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonic nelsonic nelsonic approved these changes

Assignees

@nelsonic nelsonic

Labels
in-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SimonLab @nelsonic