Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: remote_render_markdown_html/4 #23 #30

Merged
merged 3 commits into from
May 12, 2022

Conversation

nelsonic
Copy link
Member

This PR creates the Gogs.remote_render_markdown_html/4 convenience function as described in #23

@nelsonic
Copy link
Member Author

Unfortunately we're still having the issue with branch test in async: true ...
https://github.com/dwyl/gogs/runs/6403566189?check_suite_focus=true#step:8:79
image

Going to apply a sledge hammer to this!!

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #30 (be2c4e0) into main (1be6f9e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #30   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           98       109   +11     
=========================================
+ Hits            98       109   +11     
Impacted Files Coverage Δ
lib/helpers.ex 100.00% <ø> (ø)
lib/gogs.ex 100.00% <100.00%> (ø)
lib/http.ex 100.00% <100.00%> (ø)
lib/httpoison_mock.ex 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1be6f9e...be2c4e0. Read the comment docs.

Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SimonLab SimonLab merged commit 4c470c9 into main May 12, 2022
@SimonLab SimonLab deleted the remote-render-raw-html-issue-#23 branch May 12, 2022 10:37
@nelsonic
Copy link
Member Author

@SimonLab this one is ready for review. 🙏
Hopefully it's self-explanatory ... 💭
Docs published: https://hexdocs.pm/gogs/Gogs.html#remote_render_markdown_html/4

@nelsonic
Copy link
Member Author

Ah, just saw that you merged. Thanks! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants