Issue #468 handle error object passed into raise error #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add check to see if an error is passed in to raiseError and handle it accordingly
fix bug from moving reference before declaration
nelsonic
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
@virginiam1203 thanks very much for this addition to error object handling! 🎉
nelsonic
added a commit
that referenced
this pull request
Jun 4, 2024
|
@virginiam1203 your code is included in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code to address bug in Issue #468 #468
Added a check for an error object passed into the method with "boomify" and handle it accordingly so boom will not throw an "Unable to wrap non-error object" error.
Tidied up the validate_func tests to match other test files with a separate server setup. This allowed for better debugging in my experience.
Separated out tests into specific cases.
Techncially the 'ASPLODE' test was also impacted by this bug, but the test did not catch it because the Hapi server wraps any 500 error in a generic "Internal Server Error" message, so I added a new case that throws a 404 error and is broken without the bug fix.