Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge-conflicts label #26

Closed
2 tasks
nelsonic opened this issue Oct 10, 2016 · 2 comments
Closed
2 tasks

merge-conflicts label #26

nelsonic opened this issue Oct 10, 2016 · 2 comments
Assignees
Labels
awaiting-review An issue or pull request that needs to be reviewed discuss Share your constructive thoughts on how to make progress with this issue enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! T25m Time Estimate 25 Minutes

Comments

@nelsonic
Copy link
Member

nelsonic commented Oct 10, 2016

Ideally there would never be any merge conflicts in projects and everyone would be happy,
but sadly, quite often on larger projects (more than one pair of developers)
we get merge conflicts in Pull Requests.

what do people think about having a merge-conflicts label
for this so Reviewers/QA never has to (manually) write out:

"please resolve merge conflicts on this PR ..."

and everyone understands what it means when this label is applied to a PR...?

"DWYLBOT" 🤖 Automation Enhancement:

when an event happens on a pull request (e.g. new commit pushed or assignment changed etc.)
we should check all Open Pull requests on the repository for Merge Conflicts...

image

And based on the existence of merge conflicts:

  • the merge-conflicts label should be applied and
  • the PR should be assigned back to the person who created the PR.
@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality discuss Share your constructive thoughts on how to make progress with this issue labels Oct 10, 2016
@nelsonic
Copy link
Member Author

haven't had any feedback on the wording for this label...
I know I'm *Not The Only One who is seeing the merge conflicts while QA-ing PRs on projects...
But maybe others haven't Felt The Pain of having to write the same comment a thousand time:

"Hi {Name}, Please fix the merge conflicts and re-assign (back to me) for review. thanks!"

So...
I'm creating the label as resolving-merge-conflicts so it's a "doing" state.

@nelsonic nelsonic changed the title resolve-merge-conflicts label resolving-merge-conflicts label Jan 10, 2017
@nelsonic nelsonic added the help wanted If you can help make progress with this issue, please comment! label Jan 10, 2017
@iteles
Copy link
Member

iteles commented Jan 14, 2017

I personally am not as nice as you. If the build is failing or if there's a merge conflict, I assign the PR back to its creator without the niceties, so it doesn't 'cost' me much time.

It would be good to get thoughts on this from our QAs.

@nelsonic nelsonic changed the title resolving-merge-conflicts label merge-conflicts label Jan 30, 2017
@iteles iteles self-assigned this Jul 12, 2017
@iteles iteles added awaiting-review An issue or pull request that needs to be reviewed T25m Time Estimate 25 Minutes labels Jul 12, 2017
@iteles iteles closed this as completed Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review An issue or pull request that needs to be reviewed discuss Share your constructive thoughts on how to make progress with this issue enhancement New feature or enhancement of existing functionality help wanted If you can help make progress with this issue, please comment! T25m Time Estimate 25 Minutes
Projects
None yet
Development

No branches or pull requests

2 participants