Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maps #25

Merged
merged 4 commits into from Mar 1, 2017
Merged

Maps #25

merged 4 commits into from Mar 1, 2017

Conversation

jackcarlisle
Copy link
Member

ready for review

adds information on maps to the readme

#21

README.md Outdated
iex> %{animals | name: "Max"}
# %{legs: 4, name: "Max", type: "dog"}
```
**NOTE: Unlike the function method above, this syntax can only be used to UPDATE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackcarlisle same comment as in the previous PR. don't think the entire NOTE needs to be bold, just the Note: ... 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackcarlisle another superb addition! 😍

@nelsonic nelsonic removed their assignment Feb 14, 2017
Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jackcarlisle, an excellent addition!!

Good to rebase and merge once the other PR is merged in 👍

README.md Outdated
- [Documentation](#documentation)
- [Testing](#testing)
- [Data Structures](#data-structures)
- [Maps](#maps)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@iteles iteles assigned jackcarlisle and unassigned iteles Feb 16, 2017
@jackcarlisle jackcarlisle assigned iteles and unassigned jackcarlisle Feb 20, 2017
@jackcarlisle
Copy link
Member Author

@iteles rebased and ready to go

@iteles iteles added the in-review Issue or pull request that is currently being reviewed by the assigned person label Mar 1, 2017
Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! So sorry it took me this long, looks great - thank you! ❤️

@iteles iteles merged commit 41743c0 into master Mar 1, 2017
@iteles iteles deleted the maps branch March 1, 2017 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-review Issue or pull request that is currently being reviewed by the assigned person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants