Tape vs Tap issue #34 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 2 +1
Lines 13 28 +15
Branches 1 2 +1
=====================================
+ Hits 13 28 +15
Continue to review full report at Codecov.
|
…eathing room") around code examples and images
…h Testing image in README.md #34
…de in vending-machine.js
…chitecture-example from the end of both "advanced" tutorials
|
@iteles not "urgent" but good to get reviewed/merged this week. thank you! ✨ |
Closed
19 tasks
iteles
approved these changes
Nov 1, 2018
|
|
||
| If you found this _taster_ to front-end testing with Tape and JSDOM | ||
| helpful, consider reading our more _comprehensive_ example: | ||
| https://github.com/dwyl/todomvc-vanilla-javascript-elm-architecture-example |
| we _either_ need to "reset" the state of `COINS` _inside_ each test, | ||
| ***or*** we need to reset the state of `COINS` _before_ each test. | ||
|
|
||
| Here is the difference: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@iteles in preparation for releasing the "TodoMVC" example I have given this tutorial an update.
learn-tapetutorial to coverTapMigrate form Tape to Tap (Run Tests in PARALLEL!) ? #34 and explain the reasoning why someone would want to useTapinstead ofTapewith a clear use-case example. ✅Please review and merge if/when happy. thanks.