Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Restore Missing Metrics/Stats Docs #349

Closed
1 task
nelsonic opened this issue Apr 9, 2023 · 4 comments · Fixed by #352
Closed
1 task

Chore: Restore Missing Metrics/Stats Docs #349

nelsonic opened this issue Apr 9, 2023 · 4 comments · Fixed by #352
Assignees
Labels
chore a tedious but necessary task often paying technical debt help wanted If you can help make progress with this issue, please comment! priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T25m Time Estimate 25 Minutes tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written

Comments

@nelsonic
Copy link
Member

nelsonic commented Apr 9, 2023

As noted in #345 (comment) the docs for Metrics are missin from the main branch:
https://github.com/dwyl/mvp/blob/main/BUILDIT.md#14-adding-a-dashboard-to-track-metrics
image

Only the section heading remain ... 🤷‍♂️

Appear to have been changed in merge conflict resolution:
https://github.com/dwyl/mvp/blame/02869e8904dad19b4a71a2c6d306ce4376a67d1c/BUILDIT.md#L4742
image

I must have missed the deletion in a previous PR ... 🙈

Todo

@LuchoTurtle please:

@nelsonic nelsonic added help wanted If you can help make progress with this issue, please comment! T25m Time Estimate 25 Minutes priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished chore a tedious but necessary task often paying technical debt tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written labels Apr 9, 2023
@LuchoTurtle
Copy link
Member

Closing due to being a duplicate of #348

@nelsonic
Copy link
Member Author

nelsonic commented Apr 9, 2023

The issue I created contains more detail and a clear task. ✅
Just because I'm typing one-handed and taking my time to investigate the issue 🔍
so my issue was opened a couple of minutes after yours doesn't make my issue the "duplicate"... 🤣
If anything, the issue created by a Product Owner always supersedes.

Closing my issue and then posting a comment that there's "more info" in it:
image

Just makes you look like you're wasting the time of the reader and too lazy to copy over the additional info.

Top Tip: if your " boss" has made the effort to open a task,
don't step on their toes by closing the work they just did.
It's never helpful/welcome.
There are 100 other things you could be doing instead.
And on a Sunday night when I'm trying to clear my notifications and prepare for the week ahead,
wasting my time with this kind of nonsense is like a huge slap in the face.

slap

Just Don't Do it.

@nelsonic
Copy link
Member Author

nelsonic commented Apr 9, 2023

image

@LuchoTurtle
Copy link
Member

Closing my issue #348 in lieu of this one given the feedback above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a tedious but necessary task often paying technical debt help wanted If you can help make progress with this issue, please comment! priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T25m Time Estimate 25 Minutes tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants