Chore: Remove list_items schema

[nelsonic]

I captured the addition of list_items in: book/mvp/list_items

But the more I look at it, the more I feel this schema is superfluous.
Basically it's just being used as a place to store the sequence of item.cids.
It creates additional complexity without a tangible benefit other than a degree of normalisation.
But if we just put the seq field directly in the list and use papertrail to track changes,
we can achieve effectively the same result in terms of both accountability/audibility and "undo" functionality.

Todo

• Remove the list_items schema. ✂️
• Add seq field to list schema ➕
• Refactor the functions. 🧑‍💻 ♻️
• Update the docs 📝

Besides simplifying the schema so that it becomes easier to reason about and query,
I think we can speed up the items_with_timers query by inlining the sub-query.
So I want to get this done ASAP.

[nelsonic]

Tackling this now. 🧑‍💻 ⏳

[nelsonic]

snapshot: https://github.com/dwyl/mvp/blob/f46ded4c31c812770a9cf2cb4199c04ef95b0285/lib/app/list_items.ex before deleting list_items.ex.

Corresponding tests: https://github.com/dwyl/mvp/blob/f46ded4c31c812770a9cf2cb4199c04ef95b0285/test/app/list_items_test.exs

[nelsonic]

3 files deleted. code significantly simplified. all functionality preserved. zero regrets.

12 files changed, 112 insertions(+), 334 deletions(-)

Muuuuuuuuch betterer! 👌

[nelsonic]

https://github.com/dwyl/mvp/actions/runs/6080146395/job/16493657525#step:1:40

Warning: Failed to download action 'https://api.github.com/repos/actions/checkout/tarball/f43a0e5ff2bd294095638e18286ca9a3d1956744'. Error: Response status code does not indicate success: 503 (Service Unavailable).
Warning: Back off 24.429 seconds before retry.
Error: Response status code does not indicate success: 503 (Service Unavailable).

🤦‍♂️

[nelsonic]

Attempting to re-run failed job:

[nelsonic]

Still failing ... 😞

Looks like I'm heading to bed. 🛌

[nelsonic]

[nelsonic]

Checkout continues to fail:

Error: Can't use 'tar -xzf' extract archive file: /home/runner/work/_actions/_temp_308d408f-5b9e-41ff-a895-4601d0a7fcd6/032c8199-d0ef-4408-901d-2b1e5823d97f.tar.gz. return code: 2.

Lame.

[LuchoTurtle]

I've re-run the action and it seems to be working now - https://github.com/dwyl/mvp/actions/runs/6080146395/job/16499914191.

It appears to have been a degradation problem with Github Actions, as per https://www.githubstatus.com/.

I believe this can be closed now :D Looks awesome, amazing work 🥳

[nelsonic]

Thanks for taking a look @LuchoTurtle 👌
Included (excluded) in #345 ✅

[nelsonic]