Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work as is, get "unable to join: unmatched topic" error #29

Closed
ericridgeway opened this issue Sep 24, 2019 · 2 comments
Closed
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ericridgeway
Copy link

You forgot the step where you need to change socket.js to use
let channel = socket.channel("room:lobby", {})
instead of
let channel = socket.channel("topic:subtopic", {})

@nelsonic nelsonic added bug Something isn't working help wanted Extra attention is needed labels Sep 24, 2019
@nelsonic
Copy link
Member

@ericridgeway thank you for opening this issue! (glad someone was paying attention)
If you have time to create a pull request fixing the docs, please do.

@nelsonic
Copy link
Member

nelsonic commented Dec 17, 2019

I have added instructions to section 4.1: https://github.com/dwyl/phoenix-chat-example/tree/7a097643aa5b05e04321687ea6c169007a99e148#41-comment-out-lines-in-socketjs
so future learners/readers will not see the error.

@iteles please see: #33 (thanks!) 🌻

@iteles iteles closed this as completed in 69e9258 Dec 18, 2019
iteles added a commit that referenced this issue Dec 18, 2019
Fix "unable to join: unmatched topic" error #29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants