Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Phoenix v1.6 #55

Closed
4 tasks done
nelsonic opened this issue Sep 11, 2021 · 8 comments
Closed
4 tasks done

Update to Phoenix v1.6 #55

nelsonic opened this issue Sep 11, 2021 · 8 comments
Assignees
Labels

Comments

@nelsonic
Copy link
Member

nelsonic commented Sep 11, 2021

Given the recent Phoenix v1.6.0-rc.1 see: dwyl/learn-phoenix-framework#143

Todo

  • Go through this tutorial again and update to the latest Phoenix
    • Confirm if there is any added complexity or if v1.6 simplifies things.
  • Create Pull Request with changes
  • Assign PR for review

I expect this exercise to take around T2h because the tutorial is quite long and we need to test all the steps.
It might take less time, but this is the estimate. 💭

@nelsonic nelsonic added enhancement New feature or request help wanted Extra attention is needed priority-3 technical T2h labels Sep 11, 2021
@nelsonic nelsonic added this to More ToDo ThanCanEver Be Done in Nelson's List via automation Sep 11, 2021
@nelsonic nelsonic moved this from More ToDo ThanCanEver Be Done to Backlog in Nelson's List Sep 11, 2021
@nelsonic nelsonic mentioned this issue Sep 11, 2021
5 tasks
@nelsonic
Copy link
Member Author

Read through the upgrade guide: https://gist.github.com/chrismccord/2ab350f154235ad4a4d0f4de6decba7b
Looks fairly straightforward.
I'm still holding off doing it until more edge cases are ironed out so I don't have to waste too much time.

@nelsonic
Copy link
Member Author

nelsonic commented Oct 14, 2021

We've now updated quite a few of our Apps to Phoenix `1.6 without any issues: 🚀

Fairly certain we could tackle this issue/update now. 💭
@ajmeese7 if you're keen to dive in - very much appreciated - let us know how you get on.
(You should have write-access, please create a PR. Thanks!)

@ajmeese7
Copy link
Member

@nelsonic I'll get started on that now :)

Nelson's List automation moved this from Backlog (Prioritized) to Done Oct 14, 2021
@nelsonic
Copy link
Member Author

Thanks again @ajmeese7 🙌

@nelsonic
Copy link
Member Author

Testing on my localhost there are still a few things to tidy up for the 1.5.x to 1.6.x migration.
I'm following this guide: https://gist.github.com/chrismccord/2ab350f154235ad4a4d0f4de6decba7b

@nelsonic nelsonic reopened this Oct 15, 2021
Nelson's List automation moved this from Done to In progress Oct 15, 2021
@nelsonic nelsonic assigned nelsonic and unassigned ajmeese7 Oct 15, 2021
@nelsonic
Copy link
Member Author

Working on localhost:
image

@nelsonic
Copy link
Member Author

Suuuuuuuuper annoyingly, Travis-CI has decided to cap the number of "Credits" that Open Source projects get:
image

So my PR #62 is not running CI ... 🤦‍♂️ See: dwyl/learn-travis#67

But here's a screenshot of the tests passing on localhost:
image

@nelsonic
Copy link
Member Author

Replaced Travis-CI with GitHub Actions: #63

Nelson's List automation moved this from In progress to Done Oct 16, 2021
SimonLab added a commit that referenced this issue Oct 17, 2021
Create elixir.yml for GitHub Actions CI #55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Nelson's List
  
Done
Development

No branches or pull requests

2 participants