Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Codecov fix #117

Merged
merged 1 commit into from
May 2, 2024
Merged

[PR] Codecov fix #117

merged 1 commit into from
May 2, 2024

Conversation

LuchoTurtle
Copy link
Member

fixes the Codecov failing.

According to https://github.com/codecov/codecov-action#breaking-changes, with the new v4, tokenless uploads will cease to work.

@LuchoTurtle LuchoTurtle requested a review from nelsonic May 1, 2024 23:29
@LuchoTurtle
Copy link
Member Author

@nelsonic please merge

@LuchoTurtle LuchoTurtle changed the title fix: Codecov fix [PR] Codecov fix May 1, 2024
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (01fb313) to head (10510e7).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #117   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines           62        62           
=========================================
  Hits            62        62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proactively reading the docs and creating this PR. ❤️
Super lame that they've made a breaking change. 🤦‍♂️
So ... we'll need to apply this fix to all our repos ... ⏳ 🙄

@nelsonic nelsonic merged commit 8e09ca2 into main May 2, 2024
3 checks passed
@nelsonic nelsonic deleted the codecov_update branch May 2, 2024 01:30
@nelsonic
Copy link
Member

nelsonic commented May 2, 2024

nelsonic added a commit to dwyl/aws-lambda-deploy that referenced this pull request May 2, 2024
nelsonic added a commit to dwyl/labels that referenced this pull request May 2, 2024
nelsonic added a commit that referenced this pull request May 2, 2024
nelsonic added a commit to dwyl/elixir-auth-github-demo that referenced this pull request May 2, 2024
nelsonic added a commit to dwyl/phoenix-elm-starter that referenced this pull request May 2, 2024
nelsonic added a commit to dwyl/elixir-auth-google-demo that referenced this pull request May 2, 2024
nelsonic added a commit to dwyl/phoenix-liveview-chat-example that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants