Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

** (File.Error) could not read file "quotes.json": no such file or directory #19

Closed
2 tasks done
nelsonic opened this issue Mar 25, 2020 · 1 comment
Closed
2 tasks done

** (File.Error) could not read file "quotes.json": no such file or directory #19

nelsonic opened this issue Mar 25, 2020 · 1 comment
Labels
bug Something isn't working chore help wanted Extra attention is needed starter T25m

Comments

@nelsonic
Copy link
Member

nelsonic commented Mar 25, 2020 •
edited

When trying to use this in an Elixir project, we see the following error:

** (File.Error) could not read file "quotes.json": no such file or directory

This is because the quotes.json file has not bee explicitly exported.

Todo

  • Add files: ["lib/quotes.ex", "mix.exs", "README.md", "quotes.json"], to package() in mix.exs
  • Publish new version including the file!
@nelsonic nelsonic added bug Something isn't working help wanted Extra attention is needed T25m chore starter labels Mar 25, 2020
nelsonic added a commit that referenced this issue Mar 25, 2020
@nelsonic
add files (to be exported with the Elixir module) to package() in mix…
10ae6dd 
….exs #19
@nelsonic
Copy link
Member Author

Package published to https://hex.pm/packages/quotes/1.0.3 (313802f7f016ba7c301e9ffbb449f97d57358d29db1a314599d3e5485eaa38e5)

nelsonic added a commit that referenced this issue Mar 25, 2020
@nelsonic
bump package version for #19
b8ba1d3
nelsonic added a commit that referenced this issue Mar 25, 2020
@nelsonic
export quotes.json in package.json for #19
19bac41
nelsonic added a commit that referenced this issue Mar 25, 2020
@nelsonic
minor update exports quotes.json to ensure its available to Node.js/J…
6e7e362 
…avaScript and Elixir projects fixes #19
nelsonic added a commit that referenced this issue Mar 25, 2020
@nelsonic
use File.cwd in parse_json to ensure file is readable #19
fb257b3
nelsonic added a commit that referenced this issue Mar 25, 2020
@nelsonic
bump version for File.cwd #19
198a88e
nelsonic added a commit that referenced this issue Mar 25, 2020
@nelsonic
bump version #19
c6a8a12
nelsonic added a commit that referenced this issue Mar 25, 2020
@nelsonic
attempt to File.cd!("./deps/quotes/") for #19
2daf35d
nelsonic added a commit that referenced this issue Mar 26, 2020
@nelsonic
add debugging code for #19
7756f82
nelsonic added a commit that referenced this issue Mar 26, 2020
@nelsonic
add a bunch more debugging code for #19
8ee2715
nelsonic added a commit that referenced this issue Mar 26, 2020
@nelsonic
remove excess debugging code from parse_json/0 #19
2d47f13
nelsonic added a commit that referenced this issue Mar 26, 2020
@nelsonic
bump version to 1.0.5 with quotes.json File.read working. fixes #19
b39228c
nelsonic added a commit that referenced this issue Mar 26, 2020
@nelsonic
bump version to 1.0.5 to match elixir version for #19
eaa6690
@snyk-bot snyk-bot mentioned this issue Apr 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working chore help wanted Extra attention is needed starter T25m
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade quotesy from 1.0.2 to 1.0.5 boale/ngQuote
1 participant
@nelsonic