You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First, I want to thank you for curating those quotes 🎉
I just checked the quotes.json in the main branch and found multiple duplicates:
> jq '.[].text' quotes.json | sort | uniq -c | sort -nr | head
2 "When you are content to be simply yourself and don't compare or compete, everybody will respect you."
2 "There is no greater harm than that of time wasted."
2 "The path to success is to take massive, determined action."
2 "The best way to predict your future is to create it."
2 "Life isn't about finding yourself. Life is about creating yourself."
2 "He who obtains has little. He who scatters has much."
2 "All difficult things have their origin in that which is easy, and great things in that which is small."
1 "You, yourself, as much as anybody in the entire universe, deserve your love and affection."
1 "You won't skid if you stay in a rut."
1 "You will not be punished for your anger, you will be punished by your anger."
I checked the duplicates manually (see list below) and maybe we could agree on a solution for each case.
If so, I would happily volunteer with PRs to fix the issues.
1. Quote: When you are content to be simply yourself ...
Duplicated due to same author with different spellings: Lao Tzu vs Laozi.
Maybe we can settle for one spelling?
2. Quote: There is no greater harm than that of time wasted.
Same author – Michelangelo – but one entry with source and tags, the other without.
I guess we can remove the entry without source and tags.
3. Quote: The path to success is to take massive, determined action
Same author, but sometimes his full name is used, sometimes not: Anthony Robbins vs. Tony Robbins.
Tough one, but maybe we could migrate to something like Anthony "Tony" Robbins?
4. Quote: The best way to predict your future is to create it.
Same quote, but attributed to two different persons: Abraham Lincoln vs Peter Drucker.
Maybe we should fact-check it.
5. Quote: Life isn't about finding yourself. Life is about creating yourself.
Same author – Bernard Shaw – but one entry with source and tags, the other without.
I guess we can remove the entry without source and tags.
6. Quote: He who obtains has little. He who scatters has much.
Same quote, but attributed to two different persons: Lao Tzu vs. Richard Braunstein.
Maybe we should fact-check it.
7. Quote: All difficult things have their origin in that which is easy, and great things in that which is small.
Once again, different spelling of the name: Lao Tzu vs. Lao-Tzu.
Should be harmonized.
The text was updated successfully, but these errors were encountered:
Hi @pscheid92 👋
Stoked you found the repo and you have proactively opened this issue to help us decuplicate it! 🎉
Agree with all your suggestions. Pick the name that is most used e.g “Lau Tsu” in English.
Even though the Wikipedia article is titled “Laozi” https://en.m.wikipedia.org/wiki/Laozi
When a quote has been attributed to multiple people maybe let’s open an issue for each one and do a Quote Investigator https://quoteinvestigator.com lookup for each one. 🤔
We would be delighted if you have time to open a pull request with fixes. 💡
Thanks!
The misattributions now have their own issues (#43 and #44). I opened PR #42 for the remaining parts of this issue; I tried to split the changes into meaningful commits, hopefully easing the review.
Hello 👋
First, I want to thank you for curating those quotes 🎉
I just checked the
quotes.json
in the main branch and found multiple duplicates:I checked the duplicates manually (see list below) and maybe we could agree on a solution for each case.
If so, I would happily volunteer with PRs to fix the issues.
1. Quote: When you are content to be simply yourself ...
Duplicated due to same author with different spellings:
Lao Tzu
vsLaozi
.Maybe we can settle for one spelling?
2. Quote: There is no greater harm than that of time wasted.
Same author –
Michelangelo
– but one entry with source and tags, the other without.I guess we can remove the entry without source and tags.
3. Quote: The path to success is to take massive, determined action
Same author, but sometimes his full name is used, sometimes not:
Anthony Robbins
vs.Tony Robbins
.Tough one, but maybe we could migrate to something like
Anthony "Tony" Robbins
?4. Quote: The best way to predict your future is to create it.
Same quote, but attributed to two different persons:
Abraham Lincoln
vsPeter Drucker
.Maybe we should fact-check it.
5. Quote: Life isn't about finding yourself. Life is about creating yourself.
Same author –
Bernard Shaw
– but one entry with source and tags, the other without.I guess we can remove the entry without source and tags.
6. Quote: He who obtains has little. He who scatters has much.
Same quote, but attributed to two different persons:
Lao Tzu
vs.Richard Braunstein
.Maybe we should fact-check it.
7. Quote: All difficult things have their origin in that which is easy, and great things in that which is small.
Once again, different spelling of the name:
Lao Tzu
vs.Lao-Tzu
.Should be harmonized.
The text was updated successfully, but these errors were encountered: